Thread (7 messages) 7 messages, 4 authors, 2013-12-12

Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr

From: Rajeev kumar <hidden>
Date: 2013-12-11 11:09:05
Also in: linux-arm-kernel, linux-pci

On 12/11/2013 3:08 PM, Mohit KUMAR wrote:
quoted hunk ↗ jump to hunk
DT field name for the phy address changed since kernel 3.10. Set the
snps,phy-addr to 0xffffffff so that the driver probes for the phy.

Signed-off-by: Mohit Kumar<redacted>
Cc: Pratyush Anand<redacted>
Cc: Viresh Kumar<redacted>
Cc: spear-devel@list.st.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org
---
  arch/arm/boot/dts/spear13xx.dtsi |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/spear13xx.dtsi b/arch/arm/boot/dts/spear13xx.dtsi
index 4382547..3518803 100644
--- a/arch/arm/boot/dts/spear13xx.dtsi
+++ b/arch/arm/boot/dts/spear13xx.dtsi
@@ -155,6 +155,7 @@

  		gmac0: eth@e2000000 {
  			compatible = "st,spear600-gmac";
+			snps,phy-addr =<0xffffffff>;
Don't you think it should be st,phy-addr =<0xffffffff>, as the 
manufacturer is 'st' as the compatible suggest

~Rajeev

  			reg =<0xe2000000 0x8000>;
  			interrupts =<0 33 0x4
  				      0 34 0x4>;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help