RE: [PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function

Hi,

From: Kishon Vijay Abraham I [mailto:kishon@ti.com]
Sent: Monday, December 16, 2013 10:01 AM

On Friday 13 December 2013 08:56 PM, Kamil Debski wrote:

quoted

Hi Kishon,

quoted

From: Kishon Vijay Abraham I [mailto:kishon@ti.com]
Sent: Friday, December 13, 2013 3:45 PM

Hi,

On Friday 13 December 2013 07:32 PM, Kamil Debski wrote:

quoted

Previously the of_phy_get function took a struct device * and was
declared static. It was impossible to call it from another driver
and thus it was impossible to get phy defined for a given node. The
old function was renamed to _of_phy_get and was left for internal

use.

quoted

quoted

quoted

of_phy_get function was added and it was exported. The function
enables to get a phy for a given device tree node.

Signed-off-by: Kamil Debski <redacted>
---
It seems that my git send-email is playing up and sent the previous
emails without from. This is a resend. Sorry for any confusion.
---
 drivers/phy/phy-core.c  |   41 ++++++++++++++++++++++++++++++++---

--

quoted

quoted

----

quoted

 include/linux/phy/phy.h |    1 +
 2 files changed, 33 insertions(+), 9 deletions(-)

diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index

03cf8fb..f0dbd42 100644

--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c

@@ -240,8 +240,8 @@ out:
 EXPORT_SYMBOL_GPL(phy_power_off);

 /**
- * of_phy_get() - lookup and obtain a reference to a phy by

phandle

quoted

quoted

quoted

- * @dev: device that requests this phy
+ * _of_phy_get() - lookup and obtain a reference to a phy by
+ phandle
+ * @np: device_node for which to get the phy
  * @index: the index of the phy
  *
  * Returns the phy associated with the given phandle value, @@
-250,20 +250,17 @@ EXPORT_SYMBOL_GPL(phy_power_off);
  * not yet loaded. This function uses of_xlate call back function

provided

quoted

  * while registering the phy_provider to find the phy instance.
  */
-static struct phy *of_phy_get(struct device *dev, int index)
+static struct phy *_of_phy_get(struct device_node *np, int index)
 {
 	int ret;
 	struct phy_provider *phy_provider;
 	struct phy *phy = NULL;
 	struct of_phandle_args args;

-	ret = of_parse_phandle_with_args(dev->of_node, "phys", "#phy-

cells",

quoted

+	ret = of_parse_phandle_with_args(np, "phys", "#phy-cells",
 		index, &args);
-	if (ret) {
-		dev_dbg(dev, "failed to get phy in %s node\n",
-			dev->of_node->full_name);
+	if (ret)
 		return ERR_PTR(-ENODEV);
-	}

 	mutex_lock(&phy_provider_mutex);
 	phy_provider = of_phy_provider_lookup(args.np); @@ -283,6 +280,32

@@

quoted

err0:
 }

 /**
+ * of_phy_get() - lookup and obtain a reference to a phy using a

device_node.

quoted

+ * @np: device_node for which to get the phy
+ * @index: the index of the phy

Would be better if the user can get the PHY by string instead of

index.

quoted

Ok, this sounds doable. I will add of_phy_get_by_name analogous to

the

quoted

clk framework.

Nope. It was decided initially to have minimal no of APIs exported to
get PHYs.
So you can just get string as argument instead of index and leave the
name of the API to just of_phy_get.

If you say so. I just sent a new version taking a string id instead of
an index. I hope you find it satisfying.

Thanks
Kishon

quoted

quoted

quoted

+ *
+ * Returns the phy driver, after getting a refcount to it; or
+ * -ENODEV if there is no such phy.  The caller is responsible for
+ * calling phy_put() to release that count.
+ */
+struct phy *of_phy_get(struct device_node *np, int index) {
+	struct phy *phy = NULL;
+
+	phy = _of_phy_get(np, index);
+	if (IS_ERR(phy))

dev_err here?

dev_err requires a dev, so it is not possible with the arguments used.
And we do not want to add any extra parameters to keep the function
call analogous to other of_*_get (as for example of_clk_get).

Best wishes,

Best wishes,
-- 
Kamil Debski
Samsung R&D Institute Poland