Re: [PATCH 1/2] input: touchscreen: fix spelling mistake in TSC/ADC DT binding

HI,

On Thu, Nov 14, 2013 at 11:19:59AM +0000, Mark Rutland wrote:

quoted

On Tue, Oct 22, 2013 at 10:42:00AM +0200, Sebastian Andrzej Siewior wrote:

quoted

On 10/21/2013 10:13 PM, Felipe Balbi wrote:

quoted

diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index e1c5300..b61df9d 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c

@@ -348,9 +348,16 @@ static int titsc_parse_dt(struct platform_device *pdev,
 	if (err < 0)
 		return err;
 
-	err = of_property_read_u32(node, "ti,coordiante-readouts",
+	/*
+	 * try with new binding first. If it fails, still try with
+	 * bogus, miss-spelled version.
+	 */
+	err = of_property_read_u32(node, "ti,coordinate-readouts",
 			&ts_dev->coordinate_readouts);
 	if (err < 0)
+		err = of_property_read_u32(node, "ti,coordiante-readouts",
+				&ts_dev->coordinate_readouts);
+	if (err < 0)
 		return err;

Thanks, very good. Do we keep this fallback for ever or just for a year
or two?

That's for DT maintainers to decide but considering DT is an ABI, I
guess we need to keep for 30 years or so :-p

We keep it as long as we have to. If no-one's relying on the typo by the
next merge window, I see no reason we'd have to keep support for the

and how could you know that ? considering it's an ABI, how could you
ever know that ?

-- 
balbi