Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

From
Tim Kryger <hidden>
Date
2013-11-07 19:58:02
Also in
linux-arm-kernel, linux-i2c, lkml
Reply to
Wolfram Sang, 2013-11-01
On Fri, Nov 1, 2013 at 6:08 AM, Wolfram Sang [off-list ref] wrote:
On Wed, Oct 16, 2013 at 03:01:47PM -0700, Tim Kryger wrote:
quoted
Add support for I2C high-speed mode (3.4 MHz).

Signed-off-by: Tim Kryger <redacted>
Reviewed-by: Matt Porter <redacted>
Reviewed-by: Markus Mayer <redacted>
Mostly good as well:
quoted
+enum hs_bus_speed_index {
+     BCM_SPD_3P4MHZ = 0,
+};
I just realized that you should update both patches to add the supported
bus speeds to the binding documentation.
While the bus speed property is really a configuration parameter (and
not a true description of of the hardware) it seems improper to put
driver specific details into the binding document.

Please let me know how you would like me to proceed.

I should mention that I plan to break out the binding into its own
patch as this seems to be the latest best practice just in case that
influences your decision.

Thanks,
Tim Kryger
Thread (13 messages) 13 messages, 4 authors, last reply 2013-11-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help