Re: [PATCHv3 15/19] ARM: tegra: Create a DT header defining SWGROUP ID
From: Stephen Warren <hidden>
Date: 2013-10-30 22:48:38
Also in:
linux-iommu, linux-tegra
On 10/18/2013 04:26 AM, Hiroshi Doyu wrote:
Create a header file to define the swgroup IDs used by the IOMMU(SMMU) binding. "swgroups" is a group of H/W clients which Tegra SoCs support. This unique ID can be used to calculate MC_SMMU_<swgroup name>_ASID_0 register offset and MC_<swgroup name>_HOTRESET_*_0 register bit. This will allow the same header to be used by both device tree files, and drivers implementing this binding, which guarantees that the two stay in sync. This also makes device trees more readable by using names instead of magic numbers.
quoted hunk
diff --git a/include/dt-bindings/memory/tegra-swgroup.h b/include/dt-bindings/memory/tegra-swgroup.h
+#define TEGRA_SWGROUP_PPCS2 32 /* 0xab0 */ + +#define TEGRA_SWGROUP_BIT(x) (1ULL << TEGRA_SWGROUP_##x)
Isn't the DT match all 32-bit, such that the ULL suffix does nothing, and TEGRA_SWGROUP_BIT(PPCS2) == 1<<32 == fail?