Re: [PATCH V2 1/7] DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs
flat view
From: Thomas Gleixner <hidden>
Date: 2013-10-30 15:15:37
Also in:
linux-arm-kernel, linux-omap, lkml
On Wed, 30 Oct 2013, Sricharan R wrote:
quoted hunk ↗ jump to hunk
@@ -700,11 +709,22 @@ static int gic_irq_domain_xlate(struct irq_domain *d, *out_hwirq = intspec[1] + 16; /* For SPIs, we need to add 16 more to get the GIC irq ID number */ - if (!intspec[0]) + if (!intspec[0]) { *out_hwirq += 16;
Minor nit. This should be in the default implementation. The crossbar implementation will fill out_hwirq in its own way and is not interested in the +16 operation at all.
quoted hunk ↗ jump to hunk
+ ret = gic_routable_irq_domain_ops->xlate(d, controller, + intspec, + intsize, + out_hwirq, + out_type); +
quoted hunk ↗ jump to hunk
+ gic->domain = irq_domain_add_legacy(node, gic_irqs, irq_base, + hwirq_base, &gic_irq_domain_ops, gic); + } else { + if (WARN_ON(!gic_routable_irq_domain_ops)) + return;
This warning is pointless, because you have default ops now.
quoted hunk ↗ jump to hunk
+ + gic->domain = irq_domain_add_linear(node, nr_routable_irqs, + &gic_irq_domain_ops, + gic); }
Thanks, tglx