On Oct 26, 2013, at 6:31 AM, Sebastian Reichel wrote:

On Sat, Oct 26, 2013 at 01:37:57AM -0500, Kumar Gala wrote:

quoted

On Oct 25, 2013, at 5:18 PM, Sebastian Reichel wrote:

quoted

On Fri, Oct 25, 2013 at 04:41:20PM -0500, Kumar Gala wrote:

quoted

On Oct 24, 2013, at 9:48 AM, Sebastian Reichel wrote:

quoted

+- interrupt: should be one of the following
+   - <8>: For controllers compatible with twl4030

Just checking, but the interrupt is always 8 for this device?

Yes. It's currently hardcoded in drivers/mfd/twl-core.c.

The fact that is hard coded in the driver does not imply that it
should be in the device tree binding.  Is there an interrupt
controller as part of the TWL4030?

Hardware looks like this:

&twl4030 {
   compatible = "ti,twl4030";
	interrupt-controller;
	#interrupt-cells = <1>;

   twl_pwrbutton: pwrbutton {
		compatible = "ti,twl4030-pwrbutton";
		interrupts = <8>; /* 8th interrupt from the twl4030 */
	};
};

Simplified the initialization of twl4030 stuff works
like this for non DT boot:

twl4030_init(...) {
   init_subdev(...);
   init_subdev("twl4030-pwrbutton", ..., irq=8, ...);
   init_subdev(...);
};

-- Sebastian

ok, than other than Grant's comment about merging some of this together with the other twl4030 bindings, ack.

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation