Re: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.
From: Lothar Waßmann <hidden>
Date: 2013-10-17 09:43:18
Also in:
alsa-devel, linux-arm-kernel, linuxppc-dev, lkml
Hi, Xiubo Li [off-list ref] wrote: [...]
quoted hunk ↗ jump to hunk
diff --git a/sound/soc/fsl/fsl-pcm-dma.c b/sound/soc/fsl/fsl-pcm-dma.c new file mode 100644 index 0000000..c4d925e --- /dev/null +++ b/sound/soc/fsl/fsl-pcm-dma.c@@ -0,0 +1,51 @@
[...]
+
+static int fsl_sai_probe(struct platform_device *pdev)
+{
+ struct of_phandle_args dma_args;
+ int index;
+ struct resource *res;
+ struct fsl_sai *sai;
+ int ret = 0;
+ struct device_node *np = pdev->dev.of_node;
+
+ sai = devm_kzalloc(&pdev->dev, sizeof(*sai), GFP_KERNEL);
+ if (!sai)
+ return -ENOMEM;
+
+ sai->fbt = FSL_SAI_FBT_MSB;
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ sai->base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(sai->base)) {
+ ret = PTR_ERR(sai->base);
+ return ret;could be: return PTR_ERR(sai->base); [...]
+static const struct of_device_id fsl_sai_ids[] = {
+ { .compatible = "fsl,vf610-sai", },
+ { /*sentinel*/ },The comma after the last entry in a struct initializer is there to make patches that append another entry cleaner. Since this entry is and always must be the last entry, the comma is useless here.
quoted hunk ↗ jump to hunk
diff --git a/sound/soc/fsl/fsl-sai.h b/sound/soc/fsl/fsl-sai.h new file mode 100644 index 0000000..ab76a8e --- /dev/null +++ b/sound/soc/fsl/fsl-sai.h@@ -0,0 +1,127 @@ +/* + * Copyright 2012-2013 Freescale Semiconductor, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#ifndef __FSL_SAI_H +#define __FSL_SAI_H + +#include <sound/dmaengine_pcm.h> + +#define FSL_SAI_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |\ + SNDRV_PCM_FMTBIT_S20_3LE |\ + SNDRV_PCM_FMTBIT_S24_LE) + +#define FSL_SAI_DMABUF_SIZE (32 * 1024) +#define TCD_NUMBER 4 +#define EDMA_PRIO_HIGH 6 +
strange indentation with mixed spaces and tabs.
+/* SAI Transmit and Recieve Configuration 2 Register */ +#define SAI_TCR2 0x08 +#define SAI_RCR2 0x88 +#define SAI_CR2_SYNC BIT(30) +#define SAI_CR2_MSEL_MASK (0xff << 26) +#define SAI_CR2_MSEL_BUS 0 +#define SAI_CR2_MSEL_MCLK1 BIT(26) +#define SAI_CR2_MSEL_MCLK2 BIT(27) +#define SAI_CR2_MSEL_MCLK3 (BIT(26)|BIT(27))
spaces around '|'? Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________