Re: [PATCH v3 08/19] clk: tegra: add common infra for DT clocks

On Tue, Oct 15, 2013 at 09:01:43PM +0200, Stephen Warren wrote:

On 10/15/2013 08:52 AM, Peter De Schrijver wrote:

quoted

Introduce a common infrastructure for sharing clock initialization between
SoCs.

quoted

diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c

quoted

+struct clk ** __init tegra_lookup_dt_id(int clk_id,
+					struct tegra_clk *tegra_clk)
+{
+	if (tegra_clk[clk_id].present)
+		return &clks[tegra_clk[clk_id].dt_id];
+	else
+		return NULL;

Does this need range-checking? Or do we assume that since this is an
internal function, "clk_id" will never be out-of-range?

That was my assumption indeed. I could add a range check if you think that's
useful.

Cheers,

Peter.