Re: [PATCH v3 12/13] usb: phy: msm: Properly check core interrupt number
From: Felipe Balbi <hidden>
Date: 2013-10-14 23:00:23
Also in:
linux-arm-kernel, linux-arm-msm, lkml
On Mon, Oct 14, 2013 at 06:24:39PM +0300, Ivan T. Ivanov wrote:
From: "Ivan T. Ivanov" <redacted> IRQ with number 0 is valid case, so check for negative
not entirelly correct... IRQ 0 isn't supposed to be used as a linux IRQ number IIRC.
quoted hunk ↗ jump to hunk
numbers instead. Signed-off-by: Ivan T. Ivanov <redacted> --- drivers/usb/phy/phy-msm-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index ca2abe6..f34c8a9 100644 --- a/drivers/usb/phy/phy-msm-usb.c +++ b/drivers/usb/phy/phy-msm-usb.c@@ -1415,7 +1415,7 @@ static int __init msm_otg_probe(struct platform_device *pdev) dev_info(&pdev->dev, "OTG regs = %p\n", motg->regs); motg->irq = platform_get_irq(pdev, 0); - if (!motg->irq) { + if (motg->irq < 0) {
this check is correct though, since platform_get_irq() will return -ENXIO if it doesn't find IRQ resource. -- balbi