Thread (1 message) 1 message, 1 author, 2013-09-16

Re: [PATCH v4 3/3] PCI: imx6: Add support for i.MX6 PCIe controller

From: Jingoo Han <hidden>
Date: 2013-09-16 22:53:19
Also in: linux-arm-kernel, linux-pci

On Monday, September 16, 2013 6:02 PM, Shawn Guo wrote:
On Mon, Sep 16, 2013 at 02:54:32PM +0800, Sean Cross wrote:
quoted
quoted
quoted
@@ -116,6 +116,22 @@
 			arm,data-latency = <4 2 3>;
 		};
+		pcie: pcie@0x01000000 {
+			compatible = "fsl,imx6-pcie", "snps,dw-pcie";
We generally use particular SoC name to specify the compatible string.
So "fsl,imx6q-pcie" will be more appropriate.
Any reason to specify imx6q in particular?  It's also present on the
imx6d, imx6dl, and imx6s (basically, everything but the imx6sl).
The compatible naming is not about coverage but versioning.  We
generally encode the name of the SoC that firstly integrates the block
to specify the version.
Yes, you're right. :-)
The name of the first SoC would be used.

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help