Re: [PATCH v8 12/12] V4L: Add driver for s5k4e5 image sensor

On 09/13/2013 06:55 AM, Philipp Zabel wrote:

Hi Arun,

Am Donnerstag, den 12.09.2013, 17:37 +0530 schrieb Arun Kumar K:

quoted

This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
Like s5k6a3, it is also another fimc-is firmware controlled
sensor. This minimal sensor driver doesn't do any I2C communications
as its done by ISP firmware. It can be updated if needed to a
regular sensor driver by adding the I2C communication.

... [untrimmed patch] ...

quoted

+Example:
+
+	i2c-isp@13130000 {
+		s5k4e5@20 {
+			compatible = "samsung,s5k4e5";
+			reg = <0x20>;
+			gpios = <&gpx1 2 1>;

This probably should be 'reset-gpios', too.

... [untrimmed patch] ...

regards
Philipp

Please delete unnecessary context when replying so that people don't
have to scroll through hundreds of lines of patch to see a 1-line comment.