Re: [PATCH 3/4] regulator: as3722: add regulator driver for AMS AS3722
From: Stephen Warren <hidden>
Date: 2013-09-23 16:58:37
Also in:
linux-gpio, lkml
On 09/17/2013 12:45 AM, Laxman Dewangan wrote:
The AS3722 is a compact system PMU suitable for Mobile Phones, Tablet etc. It has 4 DCDC step down regulators, 3 DCDC step down controller, 11 LDOs. Add a driver to support accessing the DCDC/LDOs found on the AMS AS3722 PMIC using regulators.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/regulator/as3722-reguator.txt b/Documentation/devicetree/bindings/regulator/as3722-reguator.txt
The filename is typo'd
+AMS AS3722 regulator devicetree bindings. +The regulator node is sub node of the AS3722 node.
You probably want a blank line to separate the document title from the body text.
+Optional nodes: +- regulators : Must contain a sub-node per regulator from the list below. + Each sub-node should contain the constraints and initialization + information for that regulator. See regulator.txt for a + description of standard properties for these sub-nodes. + Additional custom properties are listed below. + sd[0-6], ldo[0-7], ldo[9-11].
I think you want to prefix that last line with something like: "Valid regulator names are: ".
+ ams,ext-control: External control of the rail. The option of + this properties will tell which external input is + controlling this rail. Valid values are 0, 1, 2 ad 3. + 0: There is no external control of this rail. + 1: Rail is controlled by ENABLE1 input pin. + 2: Rail is controlled by ENABLE1 input pin. + 3: Rail is controlled by ENABLE1 input pin.
Those last 3 lines all say the same thing.