Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

On Wed, Aug 14, 2013 at 02:34:45PM +0800, Nicolin Chen wrote:

On Wed, Aug 14, 2013 at 02:39:33PM +0800, Shawn Guo wrote:

quoted

We only need to maintain those versions that require different
programming model in the list.  For example, if S/PDIF on Vybrid
is completely compatible with imx6q one and uses the exactly same
programming model, we do not need to maintain a compatible string
for Vybrid S/PDIF at all.  Instead, we only need to have something
like below in Vybrid dts file, and S/PDIF driver will just work for it.

	compatible = "fsl,vf600-spdif", "fsl,imx6q-spdif";

Shawn

Clear. Thank you for the explain.

Then I think I can merely remain "fsl,imx6q-spdif" here,
because all other cases should be completely compatible
with this one. They are only different in the clock source
names list, which's already being specified in dts file.

Please correct me if you think this still isn't proper.

And we generally prefer to use the soc that firstly integrates the IP to
name the compatible.  For IMX series, I think imx35 is the one, so we
would name it "fsl,imx35-spdif".

Shawn