Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

On Mon, Aug 19, 2013 at 11:21:06AM +0100, Nicolin Chen wrote:

On Mon, Aug 19, 2013 at 11:01:43AM +0100, Mark Rutland wrote:

quoted

quoted

At least they are separate drivers as I mentioned in the commit comments.

I'm not sure that the boundary of Linux drivers should necessarily
determine the way we carve up the description of IP blocks, though
presumably it's a pretty sensible way of carving it up or we wouldn't
have done it.

I'm not sure if I understand your point correctly. But in fact the IP driver
is not being carved up. The spdif-transmitter and spdif-receiver are basically
dummy codec drivers. All the IP-related codes are implemented in fsl_spdif.c,
the PATCH 1/2 you just reviewed.

I see. Sorry for the noise there, that's an artifact of my not full
understanding of the ASoC bindings.

quoted

Is there any public documentation on the i.MX S/PDIF hardware block(s)?

http://cache.freescale.com/files/32bit/doc/ref_manual/IMX6DQRM.pdf

Cheers!

Mark.