Re: [PATCH v5 01/13] [media] exynos5-is: Adding media device driver for exynos5

Hi Sachin,

On Wed, Aug 14, 2013 at 10:29 AM, Sachin Kamat [off-list ref] wrote:

Hi Arun,

On 14 August 2013 10:16, Arun Kumar K [off-list ref] wrote:

quoted

From: Shaik Ameer Basha <redacted>

This patch adds support for media device for EXYNOS5 SoCs.
The current media device supports the following ips to connect
through the media controller framework.

* MIPI-CSIS
  Support interconnection(subdev interface) between devices

* FIMC-LITE
  Support capture interface from device(Sensor, MIPI-CSIS) to memory
  Support interconnection(subdev interface) between devices

* FIMC-IS
  Camera post-processing IP having multiple sub-nodes.

G-Scaler will be added later to the current media device.

The media device creates two kinds of pipelines for connecting
the above mentioned IPs.
The pipeline0 is uses Sensor, MIPI-CSIS and FIMC-LITE which captures
image data and dumps to memory.
Pipeline1 uses FIMC-IS components for doing post-processing
operations on the captured image and give scaled YUV output.

Pipeline0
  +--------+     +-----------+     +-----------+     +--------+
  | Sensor | --> | MIPI-CSIS | --> | FIMC-LITE | --> | Memory |
  +--------+     +-----------+     +-----------+     +--------+

Pipeline1
 +--------+      +--------+     +-----------+     +-----------+
 | Memory | -->  |  ISP   | --> |    SCC    | --> |    SCP    |
 +--------+      +--------+     +-----------+     +-----------+

Signed-off-by: Shaik Ameer Basha <redacted>
Signed-off-by: Arun Kumar K <redacted>
---
 .../devicetree/bindings/media/exynos5-mdev.txt     |  130 +++
 drivers/media/platform/exynos5-is/exynos5-mdev.c   | 1218 ++++++++++++++++++++
 drivers/media/platform/exynos5-is/exynos5-mdev.h   |  160 +++
 3 files changed, 1508 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/exynos5-mdev.txt
 create mode 100644 drivers/media/platform/exynos5-is/exynos5-mdev.c
 create mode 100644 drivers/media/platform/exynos5-is/exynos5-mdev.h

diff --git a/Documentation/devicetree/bindings/media/exynos5-mdev.txt b/Documentation/devicetree/bindings/media/exynos5-mdev.txt
new file mode 100644
index 0000000..007ce21
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/exynos5-mdev.txt

@@ -0,0 +1,130 @@
+Samsung EXYNOS5 SoC Camera Subsystem
+------------------------------------
+
+The Exynos5 SoC Camera subsystem comprises of multiple sub-devices
+represented by separate device tree nodes. Currently this includes: FIMC-LITE,
+MIPI CSIS and FIMC-IS.
+
+The sub-subdevices are defined as child nodes of the common 'camera' node which
+also includes common properties of the whole subsystem not really specific to
+any single sub-device, like common camera port pins or the CAMCLK clock outputs
+for external image sensors attached to an SoC.
+
+Common 'camera' node
+--------------------
+
+Required properties:
+
+- compatible   : must be "samsung,exynos5-fimc", "simple-bus"

I think it was concluded that this should be "samsung,exynos5250-fimc".

Oh yes. Actually I modified it in the code, but missed updating the binding doc.
Thanks for catching it.
Will wait for Sylwester's comments to see if the whole series should
be posted again
or just this change can be made while applying.

Regards
Arun