Hi Mark,

On Tue, Jul 30, 2013 at 8:58 AM, Padma Venkat [off-list ref] wrote:

Hi Mark,

On Mon, Jul 29, 2013 at 7:13 PM, Mark Brown [off-list ref] wrote:

quoted

On Mon, Jul 29, 2013 at 05:31:16PM +0530, Padma Venkat wrote:

quoted

On Sat, Jul 27, 2013 at 6:46 AM, Padma Venkat [off-list ref] wrote:

quoted

quoted

quoted

quoted

+     vdd: fixed-regulator@0 {
+             compatible = "regulator-fixed";
+             regulator-name = "vdd-supply";

quoted

quoted

quoted

These names look wrong - they should reflect the names in the schematic
as they're for human comprehensibility.  This may just be a case of
dropping the -supply.

quoted

When I posted the same patch for smdk5250, you asked me to club all
the same supply regulators. So I clubbed AVDD2 and CPVDD. So any other
better name for representing both supplies?

No, I'd have told you to combine things taht come from the same supply
on the board - things like the speaker supplies for example aren't going
to be coming from separate places.  The names should reflect whatever
the names on the schemaric are, like I say that's probably just removing
the -supply.

quoted

quoted

quoted

documentation update the other day, it's in my tree now) but it's not
essential and I suspect it needs some work on the clock driver side
still.

quoted

quoted

OK. I will check this.

quoted

As per schemata, input clock to MCLK1 is an oscillator clock with
16.9MHz and MCLK2 not showing any input clock. So here I need to add a
fixed rate clock with 16.9MHz as MCLK1 in the smdk board file.

quoted

Is it correct?

Yes, in the DTS (or to XCLKOUT on the AP?).

On smdk boards(atleast on smdk5250 and smdk5420) there is no XCLKOUT
funda. Codec MCLK can get clock from oscillator clock in codec master
mode or i2scdclk in codec slave mode. XCLKOUT is there in some other
variants of 5250 and 5420 where it is using other codecs than wm8994.
But the mux and divider of XCLKOUT is out of CMU. As Sylwester told it
is there in PMU registers.

Sorry for giving some what wrong info here. I verified the schemata.
There is a switch on the board which can be used to select the input
clock of codec MCLK1. We can either select oscillator clock which is
16.9MHz which is on the board or XCLKOUT which is from PMU or
i2scdclk(codec slave mode). Right now we are using oscillator clock as
input clock to MCLK1.

Thanks
Padma