Thread (5 messages) 5 messages, 3 authors, 2013-08-05

Re: [PATCH] Add device file bindings for MAPLE

From: Kumar Gala <hidden>
Date: 2013-08-01 16:05:09
Also in: linuxppc-dev

On Aug 1, 2013, at 6:02 AM, Shaveta Leekha wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Shaveta Leekha <redacted>
---
.../devicetree/bindings/powerpc/fsl/maple.txt      |   30 ++++++++++++++++++++
1 files changed, 30 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/maple.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/maple.txt b/Documentation/devicetree/bindings/powerpc/fsl/maple.txt
new file mode 100644
index 0000000..da51c5f
--- /dev/null
+++ b/Documentation/devicetree/bindings/powerpc/fsl/maple.txt
@@ -0,0 +1,30 @@
+* Freescale MAPLE Multi Accelerator Platform Engine Baseband 3
+  (MAPLE-B3)device nodes
+
+Supported chips:
+Example: B4860
+
+Required properties:
+
+- compatible:	Should contain "fsl,maple-b3-liodn" as the value
+		This identifies Multi Accelerator Platform Engine
+		Baseband 3 block.This representation is required
+		for doing the PAMU/LIODN programming on the Linux side.
This compatible makes no sense, we shouldn't be marking a full HW block with some name that is just intended for LIODN convenance.

Is this version 3 of the block?  If so a name like "fsl,maple-v3" or "fsl,maple-v3.0" would be more appropriate.

- k
+
+- reg:		offset and length of the register set for the device
+
+Devices that have LIODNs need to specify links to the parent PAMU controller
+(the actual PAMU controller that this device is connected to) and a pointer to
+the LIODN register, if applicable.

Does Maple not have any IRQs associated with it?

If you are going to have a minimal binding, at least cover the basics associated with a device.
+
+- fsl,iommu-parent
+		: <phandle>
+		This property should be present
+
+Example:
+	/* B4860 */
+	maple@800000 {
+		compatible = "fsl,maple-b3-liodn";
+		reg = <0x8000000 0x10000>;
+		fsl,iommu-parent = <&pamu1>;
+	};
-- 
1.7.6.GIT


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help