Re: [PATCH 1/7] usb: phy: omap: Add new PHY types and remove omap_control_usb3_phy_power()

On 08/06/2013 02:45 PM, Kishon Vijay Abraham I wrote:

Hi,

On Thursday 01 August 2013 07:35 PM, Roger Quadros wrote:

quoted

TYPE2 meaning has changed. It is now a USB2 phy with Power down bit in
control_dev_conf register.

Introduce TYPE3 and TYPE4 PHY. TYPE3 is USB3 phy with DPLL and individual
TX/RX power control. TYPE4 is USB2 phy with power aux register.

Update DT binding information to reflect these changes.

Also get rid of omap_control_usb3_phy_power(). Just one function
i.e. omap_control_usb_phy_power() will now take care of all PHY types.

Signed-off-by: Roger Quadros <redacted>

Tested-by: Kishon Vijay Abraham I <redacted>
but one minor comment below.

quoted

---
  Documentation/devicetree/bindings/usb/omap-usb.txt |   23 ++--
  drivers/usb/phy/phy-omap-control.c                 |  129 +++++++++++---------
  drivers/usb/phy/phy-omap-usb2.c                    |    4 +
  drivers/usb/phy/phy-omap-usb3.c                    |    6 +-
  include/linux/usb/omap_control_usb.h               |   18 ++--
  5 files changed, 100 insertions(+), 80 deletions(-)

.
.
<snip>
.
.

quoted

+    omap_control_usb_phy_power(phy->control_dev, 0);
      usb_add_phy_dev(&phy->phy);

      platform_set_drvdata(pdev, phy);

diff --git a/include/linux/usb/omap_control_usb.h b/include/linux/usb/omap_control_usb.h
index 27b5b8c..7f027d3 100644
--- a/include/linux/usb/omap_control_usb.h
+++ b/include/linux/usb/omap_control_usb.h

@@ -22,9 +22,9 @@

quoted

  struct omap_control_usb {
      struct device *dev;

-    u32 __iomem *dev_conf;
      u32 __iomem *otghs_control;
-    u32 __iomem *phy_power;
+    u32 __iomem *power;
+    u32 __iomem *power_aux;

      struct clk *sys_clk;

you can remove omap_control_usb_platform_data from here.

OK.

cheers,
-roger