On Sat, Aug 03, 2013 at 06:26:36PM +0200, Jean-Francois Moine wrote:

Russell King - ARM Linux [off-list ref] wrote:

quoted

quoted

 static struct of_device_id kirkwood_i2s_of_match[] = {
-	{ .compatible = "marvell,kirkwood-i2s" },
+	{ .compatible = "marvell,mvebu-pcm-audio" },  

quoted

You've only just introduced "marvell,kirkwood-i2s" in the previous patch.
Why introduce something and then immediately change its name?  This makes
no sense what so ever.

2 patches for 2 different purposes. The first one just adds the DT
support. It is enough for DT based kernels. But some people wanted the
device name to be changed to 'mvebu'. So, the second patch.

There is no need for the DT name to be connected to the Linux internal
platform device name, just use the final name to start with.