Re: [PATCH v5 2/4] DMA: Freescale: Add new 8-channel DMA engine device tree nodes
From: Scott Wood <hidden>
Date: 2013-07-24 19:29:17
Also in:
linuxppc-dev, lkml
Possibly related (same subject, not in this thread)
- 2013-07-24 · [PATCH v5 2/4] DMA: Freescale: Add new 8-channel DMA engine device tree nodes · <hidden>
On 07/24/2013 01:21:07 AM, hongbo.zhang@freescale.com wrote:
quoted hunk
From: Hongbo Zhang <redacted> Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch add the device tree nodes for them. Signed-off-by: Hongbo Zhang <redacted> --- .../devicetree/bindings/powerpc/fsl/dma.txt | 66 ++++++++++++++++ arch/powerpc/boot/dts/fsl/b4si-post.dtsi | 4 +- arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi | 81 ++++++++++++++++++++ arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsi | 81 ++++++++++++++++++++ arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 4 +- 5 files changed, 232 insertions(+), 4 deletions(-) create mode 100644 arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi create mode 100644 arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsidiff --git a/Documentation/devicetree/bindings/powerpc/fsl/dma.txtb/Documentation/devicetree/bindings/powerpc/fsl/dma.txt index ed703d9..54a023b2 100644--- a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt +++ b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt@@ -130,6 +130,72 @@ Example: }; }; +** Freescale Elo3 DMA Controller + This is EloPlus controller with 8 channels, used in FreescaleTxxx and Bxxx + series chips, such as t1040, t4240, b4860. + +Required properties: + +- compatible : should be "fsl,elo3-dma"
Should include "fsl,elo3-dma". There's nothing different about elo3 versus elo/eloplus regarding whether fsl,CHIP-dma is allowed. I'd just drop the references to fsl,CHIP-dma throughout the binding, and phrase the compatible description as "must include" rather than "must be" so that additional strings are allowed. -Scott