On 07/18/2013 05:14 AM, Sudeep KarkadaNagesha wrote:

On 18/07/13 09:24, Sudeep KarkadaNagesha wrote:

quoted

On 17/07/13 15:43, Andrew Lunn wrote:

quoted

On Wed, Jul 17, 2013 at 03:06:20PM +0100, Sudeep.KarkadaNagesha@arm.com wrote:

quoted

From: Sudeep KarkadaNagesha <redacted>

[...]

quoted

quoted

Are we not going a bit backwards here? You are replacing two lines
with 10 lines.

How about putting these 10 lines into some helper,
of_get_cpu_device()?  It would be useful for spear, kirkwood and
imx6q, and maybe others.

Yes I realised that after making changes to this and pmac32 drivers. I
have already made those changes in v3. I am waiting for more response
before posting them.

I thought of placing this helper in include/linux/of_device.h but I see:
#include <linux/of_platform.h> /* temporary until merge */

Does this mean of_platform.h and of_device.h will be merged ?

No, I think that was probably to avoid adding includes of of_platform.h
for 100's of files. Maybe things are cleaned up enough to remove this line.

If so, which will be the final merged one ? I would like to avoid
changing all the header file inclusions later in users of this new helper.

of_device.h is the right place.

Rob

Regards,
Sudeep


_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss