Thread (50 messages) 50 messages, 5 authors, 2013-07-10

Re: [PATCH v2 1/5] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

From: Mark Brown <broonie@kernel.org>
Date: 2013-07-08 19:40:03
Also in: alsa-devel, linux-arm-kernel, lkml

On Mon, Jul 08, 2013 at 03:29:49PM +0200, Richard Genoud wrote:
+ *		  Nicolas Ferre [off-list ref]
+ *
+ * Based on sam9g20_wm8731.c by:
+ * Sedji Gaouaou [off-list ref]
The obvious question here is of course if we can use the same driver for
both of them.
+	codec_dai->driver->playback.rates &= SNDRV_PCM_RATE_8000 |
+		SNDRV_PCM_RATE_32000 |
+		SNDRV_PCM_RATE_48000 |
+		SNDRV_PCM_RATE_96000;
+	codec_dai->driver->capture.rates &= SNDRV_PCM_RATE_8000 |
+		SNDRV_PCM_RATE_32000 |
+		SNDRV_PCM_RATE_48000 |
+		SNDRV_PCM_RATE_96000;
You definitely shouldn't be fiddling with a driver's constant static
data.  You want to be using snd_pcm_hw_constraint() APIs to set
additional constraints intead.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help