Thread (1 message) 1 message, 1 author, 2013-06-27

Re: [PATCH] leds: Add device tree binding for pca9633

From: Tony Lindgren <hidden>
Date: 2013-06-27 07:21:52

* Bryan Wu [off-list ref] [130626 16:53]:
On Wed, Jun 26, 2013 at 7:17 AM, Tony Lindgren [off-list ref] wrote:
quoted
@@ -22,6 +22,7 @@
 #include <linux/i2c.h>
 #include <linux/workqueue.h>
 #include <linux/slab.h>
+#include <linux/of.h>
 #include <linux/platform_data/leds-pca9633.h>

 /* LED select registers determine the source that drives LED outputs */
@@ -93,6 +94,61 @@ static void pca9633_led_set(struct led_classdev *led_cdev,
        schedule_work(&pca9633->work);
 }

+#ifdef CONFIG_OF
Shall we use "#if IS_ENABLED(CONFIG_OF)", as Grant pointed out recently.
Thanks will do, I'll also add the push-pull vs totem pole binding
as that can be quite crucial for some hardware configurations.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help