Re: [PATCH v2 09/10] ARM: dts: omap3: add pbias and mmc_init pinctrl states

* Balaji T K [off-list ref] [130612 10:50]:

On Wednesday 12 June 2013 08:05 PM, Tony Lindgren wrote:

quoted

* Balaji T K [off-list ref] [130606 12:20]:

quoted

add pbias states for pbias 0, 1.8V, 3V
add omap3 sd/mmc2 loop back clock config for devconf1 in mmc2_init pinctrl state
add OMAP3430 sd/mmc1 loop back clock config for devconf0 in mmc1_init pinctrl state
add OMAP3630 sd/mmc1 speed mode config for prog_io1 in mmc1_init pinctrl state

Looks OK to me, except these should be under mmc1 for omap[345].dtsi files.

I think I can move &omap3_pmx_general to omap3.dtsi and override
&pbias_1v8, &pbias_3v in omap36xx.dtsi, but I doubt pinctrl-[0,1,2,3,4]
since pull up setting can vary between boards.

OK makes sense to me if it's board specific.

Regards,

Tony