Hi Nishanth,

On Tue, Jun 25, 2013 at 3:43 PM, Nishanth Menon [off-list ref] wrote:

On 06/25/2013 07:01 AM, Nishanth Menon wrote:

quoted

On 06/25/2013 06:32 AM, Ruslan Bilovol wrote:

quoted

The OMAP4 Blaze Tablet is TI OMAP4 processor-based
development platform in a tablet formfactor.
The platform contains many of the features found in
present-day handsets (such as audio, video, wireless
functions and user interfaces) and in addition
contains features for software development and test.

This patch adds initial support for the OMAP4 Blaze
Tablet development platform. Additional functionality
depends on different drivers and code modifications that
are not upstreamed yet or do not support DT yet, so will
be added later.--

http://svtronics.com/omap/sevm4460,blaze,omap might help too :)

Yes, forgot to add this information from cover-letter from previous
version of patch :)

quoted

[...]

quoted

+
+#include "twl6030.dtsi"
+

Might be good to see the TWL interrupt pin information made available as
well?

Allow me to rephrase a comment a little bit more :)
Similar to twl4030_omap3.dtsi, we could introduce twl6030_omap4.dtsi. this
could contain the common pins used for 6030.
 &omap4_pmx_wkup {
         pinctrl-names = "default";
         pinctrl-0 = <
                         &twl6030_wkup_pins
         >;

         twl6030_wkup_pins: pinmux_twl6030_wkup_pins {
                 pinctrl-single,pins = <
                         0x14 (PIN_OUTPUT | MUX_MODE2)
                 >;
         };
 };

        twl6030_pins: pinmux_twl6030_pins {
                pinctrl-single,pins = <
                        0x15e (WAKEUP_EN | PIN_INPUT_PULLUP | MUX_MODE0)
/* sys_nirq1.sys_nirq1 */
                >;
        };

which is now already duplicated in 2 places (SDP and Panda), and in this
patch duplicated again.

Agree, I'm planning to do this later as part of moving common things into
some System-On-Module(SOM)-specific files, as discussed previously
here https://patchwork.kernel.org/patch/2118371/

Best regards,
Ruslan Bilvol

just my 2 cents :(
---
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html