Re: [PATCH v5] serial:st-asc: Add ST ASC driver.

On 25/06/13 00:38, Greg Kroah-Hartman wrote:

On Mon, Jun 24, 2013 at 08:21:43AM +0100, Srinivas KANDAGATLA wrote:

quoted

From: Srinivas Kandagatla <redacted>

This patch adds support to ASC (asynchronous serial controller)
driver, which is basically a standard serial driver. This IP is common
across all the ST parts for settop box platforms.

ASC is embedded in ST COMMS IP block. It supports Rx & Tx functionality.
It support all industry standard baud rates.

Signed-off-by: Srinivas Kandagatla <redacted>
CC: Stephen Gallimore <redacted>
CC: Stuart Menefy <redacted>
CC: Arnd Bergmann <arnd@arndb.de>
---
Hi Greg,

This patch is the part of the driver support for Stixxxx SOCs.
This patch undergone 3-4 cycles of review in arm-kernel mailing list.
As Arnd prefered to take only SOC support patches via arm-soc, Am 
sending this patch seperately.

If its not too late, can you consider this patch for 3.11 via tty tree?

I would have taken it, but it breaks the build on my machine:

Thanks Greg,

I know the problem, some of the members in struct device are conditional
with PINCTRL support.
I think that's breaking build on your machine.

I will fix it and resend as you suggested.

Thanks,
srini

drivers/tty/serial/st-asc.c: In function ‘asc_serial_resume’:
drivers/tty/serial/st-asc.c:774:15: error: ‘struct device’ has no member named ‘pins’
drivers/tty/serial/st-asc.c:775:3: error: implicit declaration of function ‘pinctrl_select_state’ [-Werror=implicit-function-declaration]
drivers/tty/serial/st-asc.c:775:37: error: ‘struct device’ has no member named ‘pins’
drivers/tty/serial/st-asc.c:776:16: error: ‘struct device’ has no member named ‘pins’

Please test your patches out on a "normal" Linux system.

Please feel free to resend this after 3.11-rc1 is out, for inclusion in
3.12, after you have fixed the build problems.

greg k-h

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss