Re: [PATCH v3 09/20] ARM: shmobile: r8a7790: Add GPIO controller devices to device tree
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2013-05-18 06:44:30
Also in:
linux-arm-kernel, linux-sh
Hi Guennadi, On Friday 17 May 2013 14:26:48 Guennadi Liakhovetski wrote:
Hi Laurent On Wed, 15 May 2013, Laurent Pinchart wrote:quoted
Add GPIO controller nodes to the r8a7790 core device tree. Signed-off-by: Laurent Pinchart [off-list ref] --- arch/arm/boot/dts/r8a7790.dtsi | 54 +++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)Also here a couple of things are missing (presumably, for other SoCs you need the same):
Thank you for testing the patch set. I'll integrate the modification in the next version for r8a7778, r8a7779 and r8a7790. As the gpio-ranges property specifies the number of GPIOs handled by the controller, what's your opinion on dropping the #gpio-lines property from the bindings ?
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/boot/dts/r8a7790.dtsib/arch/arm/boot/dts/r8a7790.dtsi index 674ee39..cd1a04f 100644--- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm/boot/dts/r8a7790.dtsi@@ -51,6 +51,7 @@ interrupts = <0 4 0x4>; #gpio-cells = <2>; gpio-controller; + gpio-ranges = <&pfc 0 0 32>; }; gpio1: gpio@ffc41000 {@@ -60,6 +61,7 @@ interrupts = <0 5 0x4>; #gpio-cells = <2>; gpio-controller; + gpio-ranges = <&pfc 0 32 32>; }; gpio2: gpio@ffc42000 {@@ -69,6 +71,7 @@ interrupts = <0 6 0x4>; #gpio-cells = <2>; gpio-controller; + gpio-ranges = <&pfc 0 64 32>; }; gpio3: gpio@ffc43000 {@@ -78,6 +81,7 @@ interrupts = <0 7 0x4>; #gpio-cells = <2>; gpio-controller; + gpio-ranges = <&pfc 0 96 32>; }; gpio4: gpio@ffc44000 {@@ -87,6 +91,7 @@ interrupts = <0 8 0x4>; #gpio-cells = <2>; gpio-controller; + gpio-ranges = <&pfc 0 128 32>; }; gpio5: gpio@ffc45000 {@@ -96,6 +101,7 @@ interrupts = <0 9 0x4>; #gpio-cells = <2>; gpio-controller; + gpio-ranges = <&pfc 0 160 32>; }; timer {@@ -118,6 +124,7 @@ pfc: pfc@e6060000 { compatible = "renesas,pfc-r8a7790"; reg = <0 0xe6060000 0 0x250>; + #gpio-range-cells = <3>; }; /* No MMC_CAP_UHS_DDR50 (dual data rate) capability on r8a7790! */
-- Regards, Laurent Pinchart