On 10/05/13 17:23, Greg KH wrote:

On Fri, May 10, 2013 at 04:45:15PM +0200, Ben Dooks wrote:

quoted

On 08/05/13 17:34, Greg KH wrote:

quoted

On Wed, May 08, 2013 at 04:34:43PM +0200, Arnd Bergmann wrote:

quoted

quoted

+#define ASC_MAJOR		204
+#define ASC_MINOR_START		40

I don't know what the current policy is on allocating major/minor numbers,
but I'm sure you cannot just reuse one that is already used.

I agree, why are you trying to create a new tty device name?  Can't you
use the existing ttyS name and minor number as you will not have any
other type of serial device on this system?

This would be an issue on systems that either accept plug-in cards
such as PCMCIA/CardBus/PCI or have additional off SoC IO spaces
where 8250 compatible UARTS could live.

I thought these were set-top box systems that couldn't accept any
plug-in cards or anything else?  This is a SoC, right?

The comment covers more than just this particular instance.

A lot of SoC devices have expansion interfaces which would accept
such UARTs.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius