Thread (1 message) 1 message, 1 author, 2013-03-28

Re: [PATCH v2 11/11] ARM i.MX6q: Add LDB device to device tree

From: Shawn Guo <hidden>
Date: 2013-03-28 14:50:01
Also in: linux-arm-kernel

On Thu, Mar 28, 2013 at 10:58:07AM +0100, Philipp Zabel wrote:
The ldb node in imx6qdl.dtsi doesn't have the di[23]_sel clocks, because
i.MX6dl doesn't have the second IPU.
On i.MX6q, di[23]_sel should point to the ipu2_di0_sel and ipu2_di1_sel
mux clocks. On i.MX6dl, di2_sel should point to lcdif_sel, eventually,
and di3_sel shouldn't be given.
Ah, sorry, I overlooked the difference.
Should I remove the clocks from imx6qdl.dtsi altogether, to avoid
confusion?
Yea, I think it's less confusing to just have clocks and clock-names
defined in imx6q and imx6dl dts respectively.
I originally intended to split the input multiplexer from the LDB
driver, as we have the same for HDMI and MIPI on i.MX6 (minus the clock
multiplexing requirements), because apart from that, the LDB blocks are
identical. Shouldn't this be documented in the device tree?
Ok, that's fine then.  I had the question because I saw imx6q compatible
already in the matching table.

Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help