Thread (1 message) 1 message, 1 author, 2013-02-13

Re: [PATCH v7 1/6] watchdog: core: dt: add support for the timeout-sec dt property

From: Wim Van Sebroeck <hidden>
Date: 2013-02-13 09:44:01
Also in: linux-watchdog

Hi Fabio,
quoted
I must admit that the different iterations of this patch only made it better.
I like the idea that you are proposing here (put the default timeout in the
watchdog_device struct and use a helper function to set the timeout parameter
value or the timeout-sec dt value). To be able to use other mechanism in the
future also, I think it make more sense to pass the device instead of the
device_node.
If i understand correctly you want to use "struct platform_device"
instead of "struct device_node",
in the function watchdog_init_timeout?
No struct device instead of struct device_node.
quoted
I also detailed your documentation a bit more and incorporated above changes
in an adjusted patch. Can you have a look at it and if OK for you I will put
it in linux-watchdog-next as your v10 :-).
That's good for sure :)
Will add it to the linux-watchdog-next tree today.

Kind regards,
Wim.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help