quoted

quoted

quoted

+#if defined(CONFIG_OF)
+static const struct of_device_id tvp514x_of_match[] = {
+       {.compatible = "ti,tvp514x-decoder", },
+       {},
+};
+MODULE_DEVICE_TABLE(of, tvp514x_of_match);
+
+static struct tvp514x_platform_data
+       *tvp514x_get_pdata(struct i2c_client *client)
+{
+       if (!client->dev.platform_data&&   client->dev.of_node) {

+               struct tvp514x_platform_data *pdata;
+               struct v4l2_of_endpoint bus_cfg;
+               struct device_node *endpoint;
+
+               pdata = devm_kzalloc(&client->dev,
+                               sizeof(struct tvp514x_platform_data),
+                               GFP_KERNEL);
+               client->dev.platform_data = pdata;

Do you really need to set client->dev.platform_data this way ?
What about passing struct tvp514x_decoder pointer to this function
and initializing struct tvp514x_decoder::pdata instead ?

Yes that can work too, I'll do the same.

Ok, thanks.

quoted

quoted

quoted

+               if (!pdata)
+                       return NULL;
+
+               endpoint = of_get_child_by_name(client->dev.of_node,
"port");
+               if (endpoint)
+                       endpoint = of_get_child_by_name(endpoint,
"endpoint");

I think you could replace these two calls above with

                 endpoint =
v4l2_of_get_next_endpoint(client->dev.of_node);

Ok

quoted

Now I see I should have modified this function to ensure it works also
when
'port' nodes are grouped in a 'ports' node.

So V5 series of V4l OF parser doesn't have this fix ?

No, it doesn't. I think we need something along the lines of:

diff --git a/drivers/media/v4l2-core/v4l2-of.c

b/drivers/media/v4l2-core/v4l2-of.c
index e1f570b..8a286f1 100644

--- a/drivers/media/v4l2-core/v4l2-of.c
+++ b/drivers/media/v4l2-core/v4l2-of.c

@@ -185,10 +185,15 @@ struct device_node *v4l2_of_get_next_endpoint(const

struct device_node *parent,
                 * This is the first call, we have to find a port within
                 * this node.
                 */
-               for_each_child_of_node(parent, port) {
+               while (port = of_get_next_child(parent, port)) {
                        if (!of_node_cmp(port->name, "port"))
                                break;
-               }
+                       if (!of_node_cmp(port->name, "ports")) {
+                               parent = port;
+                               of_node_put(port);
+                               port = NULL:
+                       }
+               };
                if (port) {
                        /* Found a port, get an endpoint. */
                        endpoint = of_get_next_child(port, NULL);

However this shouldn't affect you, as you don't use the 'ports' node...
I will likely post v6 including this fix tomorrow.