Re: [PATCH 2/2] ARM: DT: tegra: Add Toradex Iris carrier board with T20 512MB COM
From: Stephen Warren <hidden>
Date: 2013-01-17 20:57:32
Also in:
linux-arm-kernel, linux-tegra
On 01/17/2013 04:59 AM, Lucas Stach wrote:
This adds the device tree for the Toradex Iris carrier board used together with a Colibri T20 512MB COM.
quoted hunk
diff --git a/arch/arm/boot/dts/tegra20-iris-512.dts b/arch/arm/boot/dts/tegra20-iris-512.dts
+ board_regulators {Similarly, name that node just regulators
+ compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <0>;
Those properties will then already exist, so no need to duplicate them here.
+ usb_host_vbus {That would be regulator@3
+ compatible = "regulator-fixed"; + reg = <0>;
That reg = <3>; (or start numbering the board entries at say 100 to leave room for changes in the COM include file)
+ regulator-name = "usb_host_vbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-boot-on;
+ regulator-always-on;
+ gpio = <&gpio 178 0>;
+ };
+
+ vcc_sd_reg: regulator@3 {
+ compatible = "regulator-fixed";
+ reg = <1>;And the node name and reg property here would be 4.
+ regulator-name = "vcc_sd"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + }; +};
Oh and in patch 1, I noticed spaces after < or before >; could you remove those while you're at it. Thanks.