Re: [PATCH 2/2] ARM i.MX53: add dts for the TQ tqma53 module

On Wed, Jan 09, 2013 at 11:48:11AM +0800, Shawn Guo wrote:

On Mon, Jan 07, 2013 at 04:16:00PM +0100, Steffen Trumtrar wrote:

quoted

From: Sascha Hauer <redacted>

The tqma53 is an embedded module that has some features on board (e.g. emmc),
but mostly just provides access to them on its interface.
Going along with the imx53.dtsi, the tqma53.dtsi specifies the existing
devices and their pinctrl for this module. All devices that are not on the
module are disabled by default and need to be enabled in a baseboard DT.

Signed-off-by: Sascha Hauer <redacted>
Signed-off-by: Steffen Trumtrar <redacted>
---
 arch/arm/boot/dts/imx53-tqma53.dtsi |  207 +++++++++++++++++++++++++++++++++++

Please add the dtb target into arch/arm/boot/dts/Makefile.

...

Ah, yes. Forgot that.

quoted

+			usbphy1: usbphy@1 {
+				compatible = "nop-usbphy";

Is this compatible something kernel is actually using?

It is used in mainline imx25.dtsi, but maybe got there by mistake. The according
patches are floating around for a while AFAIK, but haven't made it into mainline.

I am reworking the patch according to Saschas comment and will throw everything
out, that has no mainline driver. I will also include a baseboard .dts, that uses
this .dtsi.

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |