Re: [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller

Hello.

On 01/03/2013 02:39 PM, Sergei Shtylyov wrote:

quoted

quoted

quoted

quoted

quoted

+#if defined(CONFIG_OF)
+static const struct of_device_id davinci_nand_of_match[] = {
+    {.compatible = "ti,davinci-nand", },
+    {},
+}
+MODULE_DEVICE_TABLE(of, davinci_nand_of_match);

quoted

quoted

quoted

Hmm.. maybe this crept in later after I sent the patches? They were
pending for a while ... I compiled it just yet again (based on my
tree when I posted this patch based on commit:

quoted

quoted

     I've just checked the archives: every patch version you posted had ';'
after '}' missing.

quoted

If it was built-in, rather than as a module, then MODULE_DEVICE_TABLE(…)
expands to nothing, and the structure gets to use the semicolon from the
end of that line.

   Ah, that explains it: 'davinci_all_defconfig' has CONFIG_MTD_NAND_DAVINCI=m,
so that's how the error got triggered at last. Probably worth adding this
explanation to the changelog, how do you think?

   OK, I take your silence as a sign of consent. Changelog indeed needs to be
rewritten a bit now.

WBR, Sergei

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss