Re: [PATCH 1/4] drivers: usb: phy: add a new driver for usb part of control module

Hi,

On Fri, Jan 18, 2013 at 05:40:04PM +0530, kishon wrote:

quoted

quoted

+void omap_control_usb_host_mode(struct device *dev)
+{
+	u32 val;
+	struct omap_control_usb	*control_usb = dev_get_drvdata(dev);
+
+	val = AVALID | VBUSVALID;
+
+	writel(val, control_usb->otghs_control);

I would like to make this future proof too:

val = readl(ctrl->otghs_control);
val |= OMAP_CTRL_DEV_AVALID | OMAP_CTRL_DEV_VBUSVALID;
writel(val, ctrl->otghs_control);

I think we might then have to add
val &= ~(IDDIG | SESSEND) right?

right, my bad ;-)

quoted

Another idea is to try to get the extra resource below, if it fails you
try to continue without it ;-)

I prefer the way it is now because mailbox is needed for MUSB to be
functional in OMAP4 and we should fail if we don't have it. No?

could be, that would mean an error on DT data though.

-- 
balbi