Kukjin Kim wrote:

Mark Brown wrote:

quoted

On Wed, Dec 19, 2012 at 01:24:14PM +0000, Grant Likely wrote:

quoted

On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna

[off-list ref] wrote:

quoted

quoted

+- compatible : "samsung,samsung-i2s"

quoted

Isn't that kind of redundant?  :-)

quoted

The format of the compatible strings should be "<vendor>,<part-

number>-

quoted

i2s".

quoted

Please be specific about the part number that you're doing the binding
for. For example; use "samsung,exynos4210-i2s" instead of

"samsung,exynos-i2s".

There are actually versioned IPs here (where the versions are used
publically in a few places) but it's not clearly documented which is
which.  It would be reasonable to use the IP versions here I think.

Oops, I'm resending due to problem of my e-mail client.

I agree with Mark Brown. That makes sense, for example, see mfc.
	compatible = "samsung,mfc-v6"
Same versioned IPs can be used on different SoCs, so in my opinion, in

this

case, to use version is more clear.

- Kukjin