Thread (3 messages) 3 messages, 2 authors, 2012-12-27

Re: [PATCH V2 1/2] regulator: tps51632: add register property for regmap

From: Mark Brown <hidden>
Date: 2012-12-27 17:32:37
Also in: lkml

On Tue, Dec 25, 2012 at 08:35:59PM +0530, Laxman Dewangan wrote:
All TPS51632 registers are not readable/writable and
non-volatiles.
Applied both, thanks, but you might wish to consider...
+static bool is_read_reg(struct device *dev, unsigned int reg)
+{
+	switch (reg) {
+	case 0x08 ... 0x0F:
+		return false;
+	default:
+		return true;
+	}
+}
...using the new table based stuff for the access checks, at least this
one seems to map on nicely.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help