Re: [PATCH 5/5] Input: Add ChromeOS EC keyboard driver

On Wed, Dec 19, 2012 at 8:20 PM, Simon Glass [off-list ref] wrote:

On Wed, Dec 19, 2012 at 10:16 AM, Dmitry Torokhov
[off-list ref] wrote:

quoted

On Wed, Dec 19, 2012 at 12:57:22PM +0000, Grant Likely wrote:

quoted

On Fri, 14 Dec 2012 17:43:31 -0800, Dmitry Torokhov
[off-list ref] wrote:

quoted

On Saturday, December 15, 2012 01:13:45 AM Grant Likely wrote:

quoted

quoted

+Required properties:
+- compatible: "google,cros-ec-keyb"
+- google,key-rows: Number of keyboard rows (must be <= 8)
+- google,key-columns: Number of keyboard columns (must be <= 13)
+- google,repeat-delay-ms: Key repeat delay in milliseconds
+- google,repeat-rate-ms: Key repeat rate in milliseconds

Hmmm, these should probably be in a common binding. Take a look at
the other input bindings and make a proposal for properties to add
to
matrix-keymap.txt.

Actually these are not essentia for bringup and can be set from
userspace,
so I'd say simply drop them.

Aren't they needed for a working keyboard? If so, I would really think
they should be set correctly without userspace intervention.

I am sorry if I was unclear, but I was actually talking about the last
2: repeat-delay-ms and repeat-rate-ms. Input core has I believe sane
defaults (250 msec delay, 33 cps autorepeat) and user can adjust if
other rate is preferred.

I seems like I should remove these two, then.

It would be nice if we could keep these parameters so that the keyboard
doesn't require user-space set up to work, but I understand and agree they
are not essential. Regarding Grant's request to come up with a common
binding, if I remove these then that is not needed, right?

I have no problem keeping the properties, but it does look like
something applicable to all users, not just this driver.

g.