Re: [PATCH v3 2/3] mtd: devices: elm: Add support for ELM error correction
From: Grant Likely <hidden>
Date: 2012-12-11 09:04:20
Also in:
linux-arm-kernel, linux-omap, lkml
On Thu, 29 Nov 2012 17:16:33 +0530, "Philip, Avinash" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The ELM hardware module can be used to speedup BCH 4/8/16 ECC scheme error correction. For now only 4 & 8 bit support is added Signed-off-by: Philip, Avinash <redacted> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org> Cc: Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org> --- Changes since v2: - Remove __devinit & __devexit annotations Changes since v1: - Change build attribute to CONFIG_MTD_NAND_OMAP_BCH - Reduced indentation using by passing elm_info , offset to elm_read & elm_write - Removed syndrome manipulation functions. :000000 100644 0000000... b88ee83... A Documentation/devicetree/bindings/mtd/elm.txt :100644 100644 395733a... 369a194... M drivers/mtd/devices/Makefile :000000 100644 0000000... d2667f3... A drivers/mtd/devices/elm.c :000000 100644 0000000... d4fce31... A include/linux/platform_data/elm.h Documentation/devicetree/bindings/mtd/elm.txt | 17 + drivers/mtd/devices/Makefile | 4 +- drivers/mtd/devices/elm.c | 418 +++++++++++++++++++++++++ include/linux/platform_data/elm.h | 54 ++++ 4 files changed, 493 insertions(+), 1 deletions(-)diff --git a/Documentation/devicetree/bindings/mtd/elm.txt b/Documentation/devicetree/bindings/mtd/elm.txt new file mode 100644 index 0000000..b88ee83 --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/elm.txt@@ -0,0 +1,17 @@ +Error location module + +Required properties: +- compatible: Must be "ti,elm"
Compatible string is too generic. Need to specify a specific SoC here. ie: "ti,omap3430-elm" Otherwise the binding looks fine. I haven't reviewed the code though. g.