Re: [PATCH 1/3] gpio: Add simple poweroff-gpio driver

On Thu, 15 Nov 2012 18:21:20 +0000, Grant Likely [off-list ref] wrote:

On Thu, Nov 15, 2012 at 6:11 PM, Jamie Lentin [off-list ref] wrote:

quoted

On Thu, 15 Nov 2012, Grant Likely wrote:

quoted

On Sun, 11 Nov 2012 17:21:29 +0100, Andrew Lunn [off-list ref] wrote:

quoted

From: Jamie Lentin <jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>

Given appropriate devicetree bindings, this driver registers a
pm_power_off function to set a GPIO line high/low to power down
your board.

Signed-off-by: Jamie Lentin <jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
Signed-off-by: Andrew Lunn <redacted>
---
 .../devicetree/bindings/gpio/gpio-poweroff.txt     |   22 ++++
 drivers/gpio/Kconfig                               |   10 ++
 drivers/gpio/Makefile                              |    2 +
 drivers/gpio/gpio-poweroff.c                       |  129
++++++++++++++++++++

This isn't a gpio controller driver. Don't put it into drivers/gpio

There's a v2 which puts it in drivers/power/reset/gpio-poweroff.c

Okay, thanks.

g.

So... I just read the power sequence proposal patch series which is
remarkably like a superset of what is needed here. Does it make sense to
use a power sequence for doing generic power off instead of this
interface?

g.

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.