Re: [PATCH 1/9] usb: chipidea: pci: mark platformdata as static and __devinitdata
From: Marc Kleine-Budde <hidden>
Date: 2012-11-16 10:17:49
Also in:
linux-arm-kernel
On 11/16/2012 11:06 AM, Alexander Shishkin wrote:
Michael Grzeschik [off-list ref] writes:quoted
From: Marc Kleine-Budde <redacted> Signed-off-by: Marc Kleine-Budde <redacted> Signed-off-by: Michael Grzeschik <redacted>static yes, __devinitdata -- probably not. These structs are used everywhere throughout the driver currently, not only at initialization time.
Yes, but a copy of the platform_data is used: The PCI driver calls ci13xxx_add_device(): http://lxr.free-electrons.com/source/drivers/usb/chipidea/ci13xxx_pci.c#L85 which calls platform_device_add_data(): http://lxr.free-electrons.com/source/drivers/usb/chipidea/core.c#L364 which makes a copy of the platform_data: http://lxr.free-electrons.com/source/drivers/base/platform.c#L246 Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachments
- signature.asc [application/pgp-signature] 259 bytes