Re: [PATCH 1/9] usb: chipidea: pci: mark platformdata as static and __devinitdata
From: Alexander Shishkin <hidden>
Date: 2012-11-16 10:06:57
Also in:
linux-arm-kernel
Michael Grzeschik [off-list ref] writes:
From: Marc Kleine-Budde <redacted> Signed-off-by: Marc Kleine-Budde <redacted> Signed-off-by: Michael Grzeschik <redacted>
static yes, __devinitdata -- probably not. These structs are used everywhere throughout the driver currently, not only at initialization time.
quoted hunk
--- drivers/usb/chipidea/ci13xxx_pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/usb/chipidea/ci13xxx_pci.c b/drivers/usb/chipidea/ci13xxx_pci.c index 918e149..97d25c8 100644 --- a/drivers/usb/chipidea/ci13xxx_pci.c +++ b/drivers/usb/chipidea/ci13xxx_pci.c@@ -23,17 +23,17 @@ /****************************************************************************** * PCI block *****************************************************************************/ -struct ci13xxx_platform_data pci_platdata = { +static struct ci13xxx_platform_data pci_platdata __devinitdata = { .name = UDC_DRIVER_NAME, .capoffset = DEF_CAPOFFSET, }; -struct ci13xxx_platform_data langwell_pci_platdata = { +static struct ci13xxx_platform_data langwell_pci_platdata __devinitdata = { .name = UDC_DRIVER_NAME, .capoffset = 0, }; -struct ci13xxx_platform_data penwell_pci_platdata = { +static struct ci13xxx_platform_data penwell_pci_platdata __devinitdata = { .name = UDC_DRIVER_NAME, .capoffset = 0, .power_budget = 200,-- 1.7.10.4