Re: [PATCH 01/14] pinctrl: SPEAr: add spi chipselect control driver

On Sun, Nov 11, 2012 at 5:39 AM, Viresh Kumar [off-list ref] wrote:

From: Shiraz Hashim <redacted>

SPEAr platform provides a provision to control chipselects of ARM PL022
Prime Cell spi controller through its system registers, which otherwise
remains under PL022 control which some protocols do not want.

This commit intends to provide the spi chipselect control in software
over gpiolib interface. Since it is tied to pinctrl, we place it under
'drivers/pinctrl/spear/' directory.

spi chip drivers can use the exported gpiolib interface to define their
chipselect through DT or platform data.

Cc: Linus Walleij <redacted>
Signed-off-by: Shiraz Hashim <redacted>
Reviewed-by: Vipin Kumar <redacted>
Signed-off-by: Viresh Kumar <redacted>

This sure looks good, sorry for the delay.

Just one question: since this driver is not using any
pinctrl interfaces, why is it under drivers/pinctrl/*?

Shouldn't it be under drivers/gpio from a technical
point of view?

I think I'd accept it under drivers/pinctrl/spear/*
if you just want this to keep everything SPEAr-related
in one place though, so enlighten me.

Yours,
Linus Walleij