Re: [PATCH 9/9] usb: chipidea: udc: configure iso endpoints
From: Sergei Shtylyov <hidden>
Date: 2012-11-14 18:04:29
Also in:
linux-arm-kernel
Hello. On 11/14/2012 07:19 PM, Michael Grzeschik wrote:
The implementation is derived from the fsl_udc_core code in fsl_ep_enable and makes basic iso handling possible.
Signed-off-by: Michael Grzeschik <redacted> Signed-off-by: Marc Kleine-Budde <redacted> --- drivers/usb/chipidea/udc.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
quoted hunk
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 2999b0d..0bc4308 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c@@ -1058,6 +1058,9 @@ static int ep_enable(struct usb_ep *ep, int retval = 0; unsigned long flags; + unsigned short max = 0;
It doesn't look like this initialization is necessary.
quoted hunk
+ unsigned char mult = 0; + if (ep == NULL || desc == NULL) return -EINVAL;@@ -1075,6 +1078,7 @@ static int ep_enable(struct usb_ep *ep, mEp->type = usb_endpoint_type(desc); mEp->ep.maxpacket = usb_endpoint_maxp(desc); + max = usb_endpoint_maxp(desc); dbg_event(_usb_addr(mEp), "ENABLE", 0);@@ -1082,8 +1086,12 @@ static int ep_enable(struct usb_ep *ep, if (mEp->type == USB_ENDPOINT_XFER_CONTROL) mEp->qh.ptr->cap |= QH_IOS; - else if (mEp->type == USB_ENDPOINT_XFER_ISOC) - mEp->qh.ptr->cap &= ~QH_MULT; + else if (mEp->type == USB_ENDPOINT_XFER_ISOC) { + /* Calculate transactions needed for high bandwidth iso */ + mult = (unsigned char)(1 + ((max >> 11) & 0x03)); + max = max & 0x7ff; /* bit 0~10 */
max &= 0x7ff;
+ mEp->qh.ptr->cap |= (mult << 30);
Parens not needed.
+ } else mEp->qh.ptr->cap &= ~QH_ZLT;
-- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html