Re: [PATCH v8 2/6] video: add of helper for videomode

On Tue, Nov 13, 2012 at 10:46:53AM -0700, Stephen Warren wrote:

On 11/13/2012 04:08 AM, Thierry Reding wrote:

quoted

On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote:

quoted

This adds support for reading display timings from DT or/and
convert one of those timings to a videomode. The
of_display_timing implementation supports multiple children where
each property can have up to 3 values. All children are read into
an array, that can be queried. of_get_videomode converts exactly
one of that timings to a struct videomode.

quoted

quoted

diff --git
a/Documentation/devicetree/bindings/video/display-timings.txt
b/Documentation/devicetree/bindings/video/display-timings.txt

quoted

quoted

+ - clock-frequency: displayclock in Hz

"display clock"?

I /think/ I had suggested naming this clock-frequency before so that
the property name would be more standardized; other bindings use that
same name. But I'm not too attached to the name I guess.

That's not what I meant. I think "displayclock" should be two words in
the description of the property. The property name is fine.

Thierry