RE: [PATCH 2/4] gpio: samsung: Skip registration if pinctrl driver is present on Exynos4x12
From: Kukjin Kim <hidden>
Date: 2012-11-07 04:41:44
Also in:
linux-arm-kernel, linux-samsung-soc
From: Kukjin Kim <hidden>
Date: 2012-11-07 04:41:44
Also in:
linux-arm-kernel, linux-samsung-soc
Linus Walleij wrote:
On Wed, Oct 24, 2012 at 4:37 PM, Tomasz Figa [off-list ref] wrote:quoted
This patch modifies the Samsung GPIO driver to check for pinctrl driver presence earlier and use generic matching instead of a single compatible value. This allows us to fix warning about unrecognized SoC in case of Exynos4x12, which is not supported by this driver. Signed-off-by: Tomasz Figa <redacted> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>Acked-by: Linus Walleij <redacted> Tell me if there is something you want merged through the GPIO or pinctrl tree. I have this Samsung branch on the pinctrl tree...
Hi Linus,
A commit 1b6056d6 ("pinctrl: samsung: Include bank-specific eint offset in
bank struct") which is in your pinctrl tree (samsung branch) changed
macro(EXYNOS_PIN_BANK_EINTG) to add offset. Eventually, this series(due to
3rd patch, pinctrl: samsung: Add support for Exynos4x12) breaks compilation
without the commit. So if you don't have a plan to rebase samsung branch of
your pinctrl tree, I'd like to merge it in my tree. Is it ok to you?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.