Thread (22 messages) 22 messages, 5 authors, 2012-11-28

Re: [PATCH V1 1/3] mfd: stmpe: Arrange #include <header files> in alphabetical order

From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2012-11-26 14:55:23
Also in: lkml

On 26 November 2012 18:55, Lee Jones [off-list ref] wrote:
Why do you need to sort them? Is there _really_ a need?
Many people & maintainers like to have their header files ordered. The
reason for that is:

If they are not ordered, there is a possibility of adding an header file
multiple times in a file. This might not do something serious
when thinking about compilation time or Image size, but adding an header
file multiple times is simply wrong.

This can't be caught in patch reviews most of the time, as diff may not show
the earlier inclusion.

That's why i ordered them. And i don't see any harm in doing so.

--
viresh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help