Re: [RFC] MIPS: BCM63XX: register GPIO controller through Device Tree
From: Jonas Gorski <jonas.gorski@gmail.com>
Date: 2012-11-14 12:14:07
Also in:
linux-mips, lkml
From: Jonas Gorski <jonas.gorski@gmail.com>
Date: 2012-11-14 12:14:07
Also in:
linux-mips, lkml
On 13 November 2012 06:06, Stephen Warren [off-list ref] wrote:
On 11/11/2012 05:50 AM, Jonas Gorski wrote:quoted
Register the GPIO controller through Device Tree and add the appropriate values in the include files. Since we can't register a platform driver at this early stage move the direct call to bcm63xx_gpio_init from prom_init to an arch initcall.quoted
diff --git a/Documentation/devicetree/bindings/gpio/bcm63xx-gpio.txt b/Documentation/devicetree/bindings/gpio/bcm63xx-gpio.txtquoted
+- #gpio-cells: Must be <2>. The first cell is the GPIO pin, and + the second one the standard linux flags.Also here, I think you want to explicitly document the flag values here so the bindings don't rely on the Linux kernel code. I don't think there's a standard central file which documents them though, although I vaguely recall some discussion to create add them to gpio.txt?
I'll add some more description. And yes there isn't, and I can't comment about that since I just joined devicetree-discuss a few days ago. It would be nice to have them there. Maybe I'll add a reference to gpio.txt and see if I can come up with an acceptable description for the flags. Jonas