On 10/28/2012 6:12, Mark Brown wrote:

On Mon, Oct 22, 2012 at 06:17:58PM +0800, Bo Shen wrote:

quoted

Covert sam9g20 wm8731 to device tree support
And enable it through dts file

   Tested on sam9g20 EK board

This needs to add binding documentation for the board.

I will add the binding documentation in next version.

quoted

+	dai: dai {
+		compatible = "atmel,atmel-ssc-dai";
+		atmel,dai-master = <&ssc0>;
+	};

This looks wrong - this is a Linux-specific virtual device sitting on
top of the SSC which is the actual physical device.  The usual patterns
would be something like have the machine driver register the DAI based
on the SSC specified in the bindings (much like how you're handling the
platform already).

I have a question for this, do all nodes in dts file should be physical 
device?

The SSC part is a little different with other SoC family. So, I think, 
if I keep the ssc driver in driver/misc folder as the library code. And 
create new code into sound/soc/atmel for ssc which used for audio, would 
this be acceptable? If so, the framework will be the same with other SoC 
family.